Skip to content

Screen takeover using react-modal - #6235

Closed
boblinthorst wants to merge 19 commits into
WordPress:masterfrom
Yoast:try/react-modal-screen-takeover
Closed

boblinthorst wants to merge 19 commits into
WordPress:masterfrom
Yoast:try/react-modal-screen-takeover

Conversation

@boblinthorst

@boblinthorst boblinthorst commented Apr 18, 2018 •

Copy link
Copy Markdown
Contributor

Description

In this pull, I've used react-modal to make a screen takeover. Based on the following mockups:
https://cloudup.com/cRhqngZCduC

How has this been tested?

Unit tests have been written for the actions and reducers. It has also been manually tested by adding a screen takeover from a plugin. And seeing if it works as intended.

Screenshots

screen_takeover-2

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

deleted in favor of #6241, the branch was wrong.

@boblinthorst boblinthorst added the [Status] In Progress Tracking issues with work in progress label Apr 18, 2018
@boblinthorst

Copy link
Copy Markdown
Contributor Author

deleted in favor of #6241, the branch was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] In Progress Tracking issues with work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants