Repository navigation
Latest Posts: Fix video overflow in full content mode - #61538
amitraj2203 wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi, thank you for the PR. The proposed change loads all the CSS for the video, cover and media & text blocks even when they are not on the page, including all the CSS that is unrelated to the width of the video. |
carolinan
left a comment
There was a problem hiding this comment.
Avoid loading the additional CSS when the inner blocks are not used, and limit the scope of the change to the width of videos.
|
Thank you for working on this, @amitraj2203! The underlying issue turned out to be that blocks inside the Latest Posts full content weren't being parsed, which #74866 fixed. That also loads the needed block styles only when those blocks are present, and #61477 is now closed. I'm closing this PR as superseded, but please reopen it or open a new PR if you still see video overflow on trunk. |
What?
Fixes: #61477
Why?
It makes videos contained within the allocated space in the latest posts block by setting appropriate width. Fixes overflow and overlap issues when 'Show full post' option is enabled, preventing horizontal scroll bars.
How?
Enqueues the styles for video, cover and media-text block in Latest Posts block,
Testing Instructions
Testing Instructions for Keyboard
NIL
Screenshots or screencast