Repository navigation
Conversation
| <p className="description"> | ||
| { __( 'Scales the image with a lightbox effect' ) } | ||
| </p> |
There was a problem hiding this comment.
This code has been copied/moved and is not a new string.
| </div> | ||
| <Button | ||
| icon={ linkOff } | ||
| label={ __( 'Disable expand on click' ) } |
There was a problem hiding this comment.
This code has been copied/moved and is not a new string.
This comment was marked as resolved.
This comment was marked as resolved.
| const { type, overlayOpenedBy } = getContext(); | ||
| if ( | ||
| type === 'submenu' && | ||
| // Only open on hover if the overlay is closed. |
There was a problem hiding this comment.
This comment was missed:
Also a lack of braces here, which is usually error prone and might be against the coding standards too
There was a problem hiding this comment.
Good spot. It's frustrating that that code formatting issue wasn't picked up by linting. Going to raise a PR to fix this one.
There was a problem hiding this comment.
I was annoyed at the lack of braces too but I wanted to keep the same snippet that we have above for the other handler.
|
Size Change: +77 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
3d82db4 to
b9e73ef
Compare
|
Going to work on a new branch |
What?
Contains PR cherry picked for a final (unconfirmed) packages release prior to WP 6.5.
Why?
The bugs identified were potentially severe enough to warannt a final release of packages to ensure the fixes can land in 6.5.
How?
Cherry Pick PRs
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast