Repository navigation
Font Utils: Replace join() alias with implode(). - #58845
hellofromtonya wants to merge 1 commit into
Conversation
Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning. Per Core's https://core.trac.wordpress.org/changeset/49193.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php |
|
Here's the Core commit https://core.trac.wordpress.org/changeset/57567. |
|
Flaky tests detected in e3a82b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7832234058
|
|
Thanks for keeping the plugin in sync, @hellofromtonya! The change landed in Core in r57567, and the 6.5 font compat file this PR touches was removed in #64096, so there's nothing left to update here. I'm closing this as already done. |
What?
Replaces
join()withimplode().Why?
See Core's https://core.trac.wordpress.org/changeset/49193.
This change is being tracked in https://core.trac.wordpress.org/ticket/60473 and is (or will be shortly) committed into WP Core. This PR keeps the code in sync.
Props to @david-binda.