Skip to content

Font Utils: Replace join() alias with implode(). - #58845

Closed
hellofromtonya wants to merge 1 commit into
trunkfrom
fix/font-library-use-implode-instead-of-join
Closed

hellofromtonya wants to merge 1 commit into
trunkfrom
fix/font-library-use-implode-instead-of-join

Conversation

@hellofromtonya

Copy link
Copy Markdown
Contributor

What?

Replaces join() with implode().

Why?

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

See Core's https://core.trac.wordpress.org/changeset/49193.

This change is being tracked in https://core.trac.wordpress.org/ticket/60473 and is (or will be shortly) committed into WP Core. This PR keeps the code in sync.

Props to @david-binda.

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

Per Core's https://core.trac.wordpress.org/changeset/49193.
@hellofromtonya hellofromtonya added [Type] Code Quality Issues or PRs that relate to code quality Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Typography Font and typography-related issues and PRs labels Feb 8, 2024
@github-actions

github-actions Bot commented Feb 8, 2024 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hellofromtonya <hellofromtonya@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hellofromtonya
hellofromtonya requested review from creativecoder and matiasbenedetto and removed request for spacedmonkey February 8, 2024 15:49
@hellofromtonya hellofromtonya removed the [Type] Code Quality Issues or PRs that relate to code quality label Feb 8, 2024
@github-actions

github-actions Bot commented Feb 8, 2024

Copy link
Copy Markdown

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php

@matiasbenedetto matiasbenedetto left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport.

LGTM

@hellofromtonya

Copy link
Copy Markdown
Contributor Author

Here's the Core commit https://core.trac.wordpress.org/changeset/57567.

@hellofromtonya
hellofromtonya enabled auto-merge (squash) February 8, 2024 16:05
@github-actions

github-actions Bot commented Feb 8, 2024 •

Copy link
Copy Markdown

Flaky tests detected in e3a82b1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7832234058
📝 Reported issues:

@youknowriad

Copy link
Copy Markdown
Contributor

Thanks for keeping the plugin in sync, @hellofromtonya! The change landed in Core in r57567, and the 6.5 font compat file this PR touches was removed in #64096, so there's nothing left to update here. I'm closing this as already done.

@youknowriad youknowriad closed this Oct 8, 2026
auto-merge was automatically disabled October 8, 2026 10:37

Pull request was closed

@youknowriad
youknowriad deleted the fix/font-library-use-implode-instead-of-join branch October 8, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Typography Font and typography-related issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants