Repository navigation
Conversation
|
Size Change: +61 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 57ada55. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7804001278
|
|
Does this solve for the same test setup as shown in the original Issue? Loads of links all within the same paragraph. |
Yes |
jeryj
left a comment
There was a problem hiding this comment.
It works! I looked at this for a long time and couldn't track down the source. The epitome of a tiny change for a super tricky bug. Nice job tracking this down! 👏🏻 👏🏻 👏🏻 👏🏻
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Maybe @ellatrix can provide some insight? |
|
I think we should merge this as it fixes the bug. I'd still appreciate a review from someone who knows more about this than I do. |
|
It looks like this change introduced a bug for non-iframed editors, which went unnoticed since most of our e2e tests run with iframed iframe. See details in #80396. |
What?
When handling focus events use the dom to handle.
This is an attempt to fix #58322.
Why?
I'm not totally sure what
__unstableDomOnlydoes yet. More investigation needed.How?
Pass
{ domOnly: true }toapplyRecord.We should add a test to verify the fix.
Testing Instructions
Screenshots or screencast
Feb-06-2024.17-56-10.mp4