Repository navigation
Interactivity Router: Fix initial page cache - #58496
Conversation
|
Size Change: +199 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e82e7c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7725587601
|
luisherranz
left a comment
There was a problem hiding this comment.
LGTM!
What's left to be ready for review?
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
5f67027 to
f03e339
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Epic: #56803
This PR ensures the first page is cached using the vDOM tree generated during hydration.
Why?
As the
@wordpress/interactivity-routermodule is loaded asynchronously, it currently caches the first page traversing the current DOM, which interactive blocks could have modified. This PR prevents that issue by using the same vDOM hydrated.How?
Exposing from the
@wordpress/interactivitymodule aWeakMapcalledinitialVdom, relating the generated vDOM trees with the root node where they are hydrated. ThisinitialVdomweak map is exposed from a function namedprivate APIs, which also returns other APIs meant to only be used internally.Testing Instructions