Skip to content

Update the cherry pick script to work with the new version of gh - #57917

Merged
scruffian merged 1 commit into
trunkfrom
fix/cherry-pick-script
Jan 17, 2024
Merged

scruffian merged 1 commit into
trunkfrom
fix/cherry-pick-script

Conversation

@scruffian

Copy link
Copy Markdown
Contributor

What?

The latest version of gh outputs this for auth status:

Logged in to github.com account.... instead of Logged in to github.com as.

This changes the condition under which we check that someone is logged in to work with both versions.

Testing Instructions

Update to the latest version of gh
Try running the script npm run other:cherry-pick "Backport to Gutenberg RC" but then cancel it before it runs.
On trunk you'll see an error that gh isn't installed. On this branch you should see a message telling you what will change.

@scruffian scruffian self-assigned this Jan 17, 2024
@scruffian scruffian added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 17, 2024
Comment thread bin/cherry-pick.mjs
title,
pull_request,
} ) )
const PRs = items

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all just linting changes.

@scruffian
scruffian requested a review from mikachan January 17, 2024 11:59
@scruffian
scruffian marked this pull request as ready for review January 17, 2024 11:59
@scruffian scruffian added Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) and removed Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) labels Jan 17, 2024

@mikachan mikachan left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the version of this script in trunk, I'm seeing this error message: Github CLI is not setup. With this PR, I'm able to continue to run the cherry-pick script.

LGTM!

@scruffian
scruffian enabled auto-merge (squash) January 17, 2024 12:03
@scruffian
scruffian merged commit 6b224fc into trunk Jan 17, 2024
@scruffian
scruffian deleted the fix/cherry-pick-script branch January 17, 2024 12:30
@github-actions github-actions Bot added this to the Gutenberg 17.6 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants