Repository navigation
Fix flaky 'Post publish button' e2e test - #57407
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #35641.
PR fixes flaky
should be disabled when post is being savede2e test.Why?
The e2e test failed a few dozen times in two weeks due to incorrect route interception. The draft posts only have the post ID available in the page URL once saved for the first time.
P.S. I realized that later, UI Mode provides hints in the Network tab when a route is intercepted. Best tool for debugging 🐛
How?
Switch to more generic URL matches and only intercept
POSTrequests.Testing Instructions
Screenshots or screencast