Repository navigation
Conversation
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
|
Thanks for the PR! To be honest, I am leaning towards not moving forward with this PR and revert #48254 itself. Personally, I think the issue raised in #48040 is because I believe it is the behavior that was originally expected. Here is my opinion, and I'd like to hear your thoughts if you don't mind. |
|
I have tested this PR again. The paste itself is done correctly, but all inline formatting seems to disappear. 3964c42493c772d9d6878884ae988714.1.mp4Also, from the discussion being had in #48040, it seems ideal that when text from a heading block is pasted into a paragraph block, it should be pasted inline, rather than inserting a new heading block. This PR does not cover it, should this issue be addressed in another PR? |
83f0d1a to
5a345e4
Compare
5a345e4 to
011ccc3
Compare
|
@t-hamano, sorry, was accidentally using plain text instead of HTML. Should be fixed now. |
|
Thanks for the update! I think it is working as expected. However, I noticed that when I copy the caption or cite text in a block and paste it into a paragraph block, it is converted to a Custom HTML block 😅 This problem does not reproduce when the Gutenberg plugin is disabled. The changes made since the Gutenberg version bundled with WordPress 6.3 may have caused this bug. It would be great if you could test it on MacOS as well, as it may possibly only occur on Windows. Therefore, if we backport this PR to 6.3.X, we might want to be careful not to cause this bug as well. This issue can be seen at around 18 seconds in the following screencast. bf50d8111e0ede0b5a94e539998ab437.mp4 |
I have found that this problem is caused by #48254. If the copied text is inline rich text, we may need to avoid copying tag names. This PR depends on #48254, so if we backport this PR, we may need to resolve this issue together with this PR. |
|
Hm, ok. Maybe we should revert after all. |
|
Done in #54301. |
Agreed this is an expectation; probably another? |
|
What remains to be done to move this forward? |
|
@Mamaduka could you take a look here if you happen to have time? |
|
Ah! Apologies. I misunderstood the order of things here. |
|
Right, apologies, this can be closed now. |
What?
Fixes #53422. This is a regression caused by #48254.
Why?
How?
Restores the codepath for mode=INLINE
Testing Instructions
copy a paragraph and paste it in a quote citation or image caption
Testing Instructions for Keyboard
Screenshots or screencast