Repository navigation
Conversation
jffng
reviewed
Jul 11, 2023
jffng
left a comment
Contributor
There was a problem hiding this comment.
Should this variation be available outside the navigation block? Is there a way to restrict it to the nav block only?
| @@ -5,6 +5,7 @@ export const DEFAULT_BLOCK = { | |||
| export const ALLOWED_BLOCKS = [ | |||
| 'core/navigation-link', | |||
| 'core/search', | |||
Contributor
There was a problem hiding this comment.
Would match the current behavior more closely core/search was not allowed, and only the inline variation is?
|
Size Change: +168 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5a71d65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5525622783
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds an inline variation the can be used in the navigation block
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast