Skip to content

Performance tests: update base point to compare - #51381

Merged
oandregal merged 1 commit into
trunkfrom
try/perf-tests-to-use-wp-major-sha
Jun 9, 2023
Merged

oandregal merged 1 commit into
trunkfrom
try/perf-tests-to-use-wp-major-sha

Conversation

@oandregal

@oandregal oandregal commented Jun 9, 2023 •

Copy link
Copy Markdown
Member

What?

Update the base commit we use in the performance tests. For each WordPress release, we need to update this commit.

Why?

We need a commit that is compatible with the current WP version.

How?

Took the latest commit in the wp/6.2 branch, 843a305

@oandregal
oandregal requested a review from youknowriad June 9, 2023 14:16
@oandregal oandregal self-assigned this Jun 9, 2023
@oandregal oandregal added the [Type] Performance Related to performance efforts label Jun 9, 2023
We cannot use the wp/6.2 as an alias. The reason is that the branch
is updated for minor and security releases as well (6.2.1, 6.2.2, etc.).
@oandregal
oandregal force-pushed the try/perf-tests-to-use-wp-major-sha branch from 7c4e959 to 1387eb8 Compare June 9, 2023 14:41
@oandregal
oandregal marked this pull request as ready for review June 9, 2023 14:47
@github-actions

github-actions Bot commented Jun 9, 2023 •

Copy link
Copy Markdown

Flaky tests detected in 1387eb8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5223095210
📝 Reported issues:

@oandregal
oandregal merged commit 8db07c1 into trunk Jun 9, 2023
@oandregal
oandregal deleted the try/perf-tests-to-use-wp-major-sha branch June 9, 2023 15:45
@github-actions github-actions Bot added this to the Gutenberg 16.1 milestone Jun 9, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
We cannot use the wp/6.2 alias. The reason is that the branch is updated for minor and security releases as well (6.2.1, 6.2.2, etc.), so it's a moving target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Performance Related to performance efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants