Skip to content

Update the Save Button label when you're previewing a theme - #51361

Merged
scruffian merged 1 commit into
WordPress:trunkfrom
okmttdhr:update/block-theme-previews-save-label
Jun 9, 2023
Merged

scruffian merged 1 commit into
WordPress:trunkfrom
okmttdhr:update/block-theme-previews-save-label

Conversation

@okmttdhr

@okmttdhr okmttdhr commented Jun 9, 2023 •

Copy link
Copy Markdown
Contributor

What?

Update the Save Button label when you're previewing a theme.

Why?

The Site Edotor's Save Button was updated in #50567, but it needed to make sense when previewing a theme. See #50983.

How?

  • Early return a label if isPreviewingTheme() is true

Testing Instructions

  • Go to /wp-admin/themes.php
  • Click the Live Preview button on a theme installed

Screenshots or screencast

Screen.Recording.2023-06-09.at.14.28.51.2.small.mov

@okmttdhr okmttdhr changed the title Fix the save button label for BTP Update the Save Button label when you're previewing a theme Jun 9, 2023
@okmttdhr
okmttdhr force-pushed the update/block-theme-previews-save-label branch from 19d5eb8 to be8e558 Compare June 9, 2023 05:42
@okmttdhr
okmttdhr marked this pull request as ready for review June 9, 2023 06:24

@scruffian scruffian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian
scruffian merged commit 7b6e430 into WordPress:trunk Jun 9, 2023
@github-actions github-actions Bot added this to the Gutenberg 16.1 milestone Jun 9, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@okmttdhr
okmttdhr deleted the update/block-theme-previews-save-label branch June 15, 2023 01:22
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs User Documentation Needs new user documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants