Repository navigation
Rename directives suffix character and island directive in the Interactivity API - #51152
Merged
SantosGuillamot merged 1 commit intoJun 1, 2023
Merged
Conversation
SantosGuillamot
requested review from
DAreRodz and
luisherranz
and removed request for
ajitbohra and
spacedmonkey
June 1, 2023 07:51
|
Size Change: +28 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
luisherranz
approved these changes
Jun 1, 2023
luisherranz
left a comment
Member
There was a problem hiding this comment.
LGTM Mario! Thanks for taking care of this 🙂
SantosGuillamot
deleted the
update/rename-suffix-and-island-interactivity-api
branch
June 1, 2023 09:17
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Incorporate the changes made in the Block Interactivity Experiments repo to:
data-wp-on.clicktodata-wp-on--click.data-wp-islandto `data-wp-interactive.Apart from that, I updated the current blocks using the Interactivity API as an experiment to match these changes.
Why?
In the Block Interactivity Experiments repo, these changes were made because:
How?
I just copied and paste the changes from the original pull request and:
data-wp-on--instead of the dot.data-wp-islandfordata-wp-interactive.Testing Instructions