Skip to content

Remove BaseField component - #47911

Merged
youknowriad merged 1 commit into
trunkfrom
remove/base-field
Feb 9, 2023
Merged

youknowriad merged 1 commit into
trunkfrom
remove/base-field

Conversation

@youknowriad

Copy link
Copy Markdown
Contributor

I've noticed that we have this component that is not used or exported anywhere. So it's not clear to me why we're keeping its code around. I believe it's probably a leftover from the G2 components migration to the Gutenberg repository. So I'm just removing it in this PR.

@youknowriad youknowriad added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 9, 2023
@youknowriad youknowriad self-assigned this Feb 9, 2023
@github-actions

github-actions Bot commented Feb 9, 2023

Copy link
Copy Markdown

Flaky tests detected in 0254072.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4132738390
📝 Reported issues:

@fabiankaegy fabiankaegy left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this component isn't used anywhere by searching through the codebase. And since it isn't exported this removal looks good to me 👍

That being said I don't have much insight into how all of the G2 components were brought over.

@ciampo

ciampo commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

I can confirm, it looks like BaseField was part of the g2 suite of components. It looks like it's at the foundation of some other g2 components, like Select and TextField, which I believe never got introduced to this repository when the g2 migration slowed down.

It should be safe to remove it, thank you! We can always look at reintroducing it if/when working on an evolution of these components.

@ciampo ciampo added the [Package] Components /packages/components label Feb 9, 2023
@youknowriad
youknowriad merged commit b4a1cbf into trunk Feb 9, 2023
@youknowriad
youknowriad deleted the remove/base-field branch February 9, 2023 10:15
@github-actions github-actions Bot added this to the Gutenberg 15.2 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants