Repository navigation
Remove BaseField component - #47911
Merged
Merged
Conversation
youknowriad
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
February 9, 2023 09:19
|
Flaky tests detected in 0254072. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4132738390
|
fabiankaegy
approved these changes
Feb 9, 2023
Contributor
|
I can confirm, it looks like It should be safe to remove it, thank you! We can always look at reintroducing it if/when working on an evolution of these components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that we have this component that is not used or exported anywhere. So it's not clear to me why we're keeping its code around. I believe it's probably a leftover from the G2 components migration to the Gutenberg repository. So I'm just removing it in this PR.