Skip to content

Typography block supports: call tear_down in tests and format PHP doc blocks - #43968

Merged
ramonjd merged 1 commit into
trunkfrom
update/typography-block-supports-formatting
Sep 8, 2022
Merged

ramonjd merged 1 commit into
trunkfrom
update/typography-block-supports-formatting

Conversation

@ramonjd

@ramonjd ramonjd commented Sep 8, 2022

Copy link
Copy Markdown
Member

What?

  • Standardizing PHP doc comments for tests and new methods.
  • Replaced parent::set_up(); with parent::tear_down();.

Why?

I found some issues while backporting to Core: WordPress/wordpress-develop#3203

Testing Instructions

Tests should pass!
No typos! 🤞

Replaced parent::set_up(); with parent::tear_down();.
@ramonjd ramonjd added [Type] Developer Documentation Documentation for developers [Type] Code Quality Issues or PRs that relate to code quality [Feature] Typography Font and typography-related issues and PRs labels Sep 8, 2022
@ramonjd ramonjd self-assigned this Sep 8, 2022
@ramonjd ramonjd changed the title Typography: call tear_down in tests and format PHP doc blocks Typography block supports: call tear_down in tests and format PHP doc blocks Sep 8, 2022

@Mamaduka Mamaduka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ramonjd.

No typos! 🤞

We need Grammarly GitHub action for this 😄

@ramonjd
ramonjd merged commit 40c1212 into trunk Sep 8, 2022
@ramonjd
ramonjd deleted the update/typography-block-supports-formatting branch September 8, 2022 08:10
@github-actions github-actions Bot added this to the Gutenberg 14.1 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Typography Font and typography-related issues and PRs [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants