Repository navigation
Promote Avatar and Discussion settings to stable - #40095
cbravobernal wants to merge 2 commits into
Conversation
|
Size Change: -526 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
| * | ||
| * @return array Filtered editor settings. | ||
| */ | ||
| function extend_block_editor_settings_with_discussion_settings( $settings ) { |
There was a problem hiding this comment.
It's a filter so it won't be backported the same way. It doesn't need to be guarded with a function call. It's engough to prefix the function name with gutenberg_.
|
What do we do about the Post Author block? Should we mark it as deprecated and hide from the inserter? Should we expose Post Author name or should we work on the generalized version of the Author Name block that works with both comments and posts like the Avatar one? |
I've made a POC and you can do with a pattern the same content as the Post Author block right now. So it seems that deprecating Post Author block should not be a problem. Still, we would need the Post Author Biography and Post Author Name to create it. Creating a generic Author Name would be ideal, could be possible to move this to stable, land on 6.0, and then land a generic Author Name in 6.1 or future versions? Or should we land everything together (so that we don't have duplicated patterns on the directory in the future)? |
|
My $0.02 is that I'd rather not have a duplicated pattern in the future – I can picture myself choosing the wrong one month after month :D cc @mtias |
| */ | ||
| function gutenberg_extend_block_editor_settings_with_discussion_settings( $settings ) { | ||
|
|
||
| $settings['discussionSettings'] = array( |
There was a problem hiding this comment.
Let's keep this setting experimental for now. We should look for a more general way to expose site options.
| */ | ||
| function gutenberg_extend_block_editor_settings_with_discussion_settings( $settings ) { | ||
|
|
||
| $settings['discussionSettings'] = array( |
There was a problem hiding this comment.
Let's keep this setting experimental for now. We should look for a more general way to expose site options.
|
I opened #40186 which includes some of the changes from this PR. It also enables other blocks for exposure in WordPress core. |

We found a bug on Avatar that should be fixed first. (Avatar User setting field should not appear in site editor inside a comments query loop.)
#40100 fixes it.
What?
Promote Avatar block to stable.
Promote Discussion Settings to stable.
Why?
After some testing (we have still one bug pending). We consider the Avatar block ready to be stable. This way we can use it for creating patterns.
Moving Discussion Settings function to stable will allow us to access those settings on the editor, so both Avatar and future Comments blocks will be able to use them.
How?
Testing Instructions