Skip to content

fix text columns undefined index - #3714

Merged
mtias merged 1 commit into
WordPress:masterfrom
vladanost:fix/text-columns-undefined-index
Nov 29, 2017
Merged

mtias merged 1 commit into
WordPress:masterfrom
vladanost:fix/text-columns-undefined-index

Conversation

@vladanost

Copy link
Copy Markdown
Contributor

Description

Fixes #3710

When adding new columns new index does not exist in the content array.

How Has This Been Tested?

npm run test-unit
Manually tested in the browser

Types of changes

Checking for the index before use. That seemed like an easiest fix. I could maybe try to push empty array to content on RangeControl change?

@mtias

mtias commented Nov 29, 2017

Copy link
Copy Markdown
Member

Oh, thanks, I missed this when opening #3715.

@vladanost

Copy link
Copy Markdown
Contributor Author

@mtias It's OK, should I close this one?

@mcsf mcsf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @vladanost!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled error when adding or removing columns in Text Columns

3 participants