Skip to content

Do not dispatch changes on block attribute hover on and off - #36416

Closed
zaguiini wants to merge 1 commit into
WordPress:trunkfrom
zaguiini:remove/dispatch-block-editor-attributes-changes-on-hover
Closed

zaguiini wants to merge 1 commit into
WordPress:trunkfrom
zaguiini:remove/dispatch-block-editor-attributes-changes-on-hover

Conversation

@zaguiini

Copy link
Copy Markdown
Member

Description

TBD

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@zaguiini

zaguiini commented Nov 11, 2021 •

Copy link
Copy Markdown
Member Author

This is necessary for #23041 to work properly. However, the solution on #23041 is not the best possible since it makes the changes object dirty without any actual changes.

A possible solution would be to introduce a new piece of state that would have the visualizer itself, and not pollute the changes object, thus not triggering a false alarm.

@zaguiini zaguiini closed this Nov 11, 2021
@zaguiini
zaguiini deleted the remove/dispatch-block-editor-attributes-changes-on-hover branch November 11, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant