Repository navigation
stripHTML - preserve leading and trailing spaces and strip script and on* attributes - #35539
Conversation
|
Size Change: -1.17 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Shall we cherry pick the tests from #35457 as a way of asserting this works as expected? |
25b9bcc to
76ca4f9
Compare
|
@getdave I added them. They're passing locally so that looks good. |
There was a problem hiding this comment.
This seems good and all the tests are passing (thanks for pulling those in).
One small spelling nit (caused by me!).
One thought - should we update the package CHANGELOG to note that this function no longer strips whitespace? I mean...it's a bugfix right?
|
I don't mind looking into it, seeing as that was my PR, and it's something I haven't tackled since. |
talldan
left a comment
There was a problem hiding this comment.
LGTM, should've realised this was an option earlier. 😄
Thanks for the patience on this, sorry for holding it up!
|
Glad to see this merged 😄 |
Description
Alternative to #35457.
How has this been tested?
Added unit tests.
See #35457.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).