Repository navigation
Popover: fix __unstableBoundaryParent - #35082
Merged
Merged
Conversation
jasmussen
approved these changes
Sep 23, 2021
|
Size Change: +1.95 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks for the added test! |
ellatrix
force-pushed
the
fix/popover-boundary-parent
branch
from
September 24, 2021 08:36
b7580c8 to
a5788e4
Compare
Member
|
This PR might require a rebase. RNMobile tests issue should be fixed after #34886. |
ellatrix
force-pushed
the
fix/popover-boundary-parent
branch
from
September 29, 2021 10:39
a5788e4 to
e3f26a9
Compare
Member
Author
|
Seem like making a test case is quite hard (it's a visual problem). Let's just fix the issue and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Fixes #34053.
Fixes #32402.
Regressed in #31134 because the block toolbar is no longer rendered in a slot.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).