Repository navigation
[RNmobile] Fix iOS inserter search focus issue - #34336
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
1 of 2 tasks
mchowning
approved these changes
Aug 26, 2021
mchowning
left a comment
Contributor
There was a problem hiding this comment.
Fix is working well, and code looks good! ![]()
guarani
approved these changes
Aug 26, 2021
guarani
left a comment
Contributor
There was a problem hiding this comment.
This is working great!
I first reproduced the issue on trunk using an external keyboard connected to a physical iPhone. Then I switched to this branch and verified the fix works by using the block inserter search while still on the external keyboard.
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the inserter search input losses focus immediately when tapped.
The issue is iOS only.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3877
How has this been tested?
Connect Hardware Keyboardoption selected.Screenshots
Types of changes
#34278 introduced a fix for cases when the inserter search was active and the keyboard is manually closed on Android. This left the inserter in an active state when , with the keyboard closed, should return to an inactive state.
This changes that flow to apply to Android only.
Checklist:
*.native.jsfiles for terms that need renaming or removal).