Repository navigation
Conversation
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
1033beb to
de352b0
Compare
geriux
left a comment
There was a problem hiding this comment.
This is working well for me but as you mentioned it only takes into account px values, I created a Buttons block from the web editor using a different unit rem, then open it in the mobile editor, and the correct value shows but of course we are not showing that it's in rem. If we update that value then it's stored in pixels (as expected).
Question: This PR doesn't take into account the other possible units that we could add support for. (for example em, rem) Should we try to address that in this PR as well?
I guess it depends if we want to make it partially work or add the full functionality. Do we know if we want to have a fix for the latest mobile editor release?
I would expect us to add the full functionality for options that are available. |
|
I created another PR #33434 that adds the unit control to the button block |
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3723
Description
This PR adds the unit (px) value to the button radius attribute.
In #31483 the border radius allowed for other unit types.
Which meant that the border radius once saved in the mobile Gutenberg editor didn't show up as expected.
Question: This PR doesn't take into account the other possible units that we could add support for. (for example em, rem) Should we try to address that in this PR as well?
How has this been tested?
Screenshots
There are no visual changes.
Types of changes
Fixes the changes that broke in mobile.
Checklist:
*.native.jsfiles for terms that need renaming or removal).