Skip to content

[Mobile] - Changelog update for color/background customization - #33250

Merged
geriux merged 2 commits into
trunkfrom
rnmobile/colors-update-changelog
Jul 7, 2021
Merged

geriux merged 2 commits into
trunkfrom
rnmobile/colors-update-changelog

Conversation

@geriux

@geriux geriux commented Jul 7, 2021 •

Copy link
Copy Markdown
Member

Description

Adds an entry to the changelog for the color/background customization for text blocks.

This work was added in the following PRs:

Note: This does not enable Global styles since this is still under a feature flag but it does enable color/background customization for text blocks using either the theme palette or custom colors.

For now, it only supports changing the text color on block level, not per selected words.

How has this been tested?

Test case 1: Change the text color of a Paragraph block

  • Open the mobile editor
  • Add a Paragraph block and type some text
  • Open the block settings
  • Expect to see the new Color and background options
  • Select a color for the block
  • Expect to see the text with the new selected color

Test case 2: Change the background and text color of a Paragraph block

  • Open the mobile editor
  • Add a Paragraph block and type some text
  • Open the block settings
  • Select a background color
  • Select a text color
  • Expect to see the selected color and background in the block as well as some added padding when a background color is selected.

Test case 3: Reset color selection to the default

  • Open the mobile editor
  • Add a Paragraph block and type some text
  • Open the block settings
  • Select a color for the block
  • Expect to see the text with the new selected color
  • Open the block settings
  • Select the color setting
  • On the bottom right tap on Reset
  • Expect to see the default color

Screenshots

Test case 1 Test case 2 Test case 3

Types of changes

Changelog update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 7, 2021
@geriux
geriux requested a review from antonis July 7, 2021 08:27
@geriux
geriux marked this pull request as ready for review July 7, 2021 08:27

@antonis antonis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @geriux 👍
Thank you for adding the release note and detailed testing steps 🙇

@geriux
geriux merged commit e41403d into trunk Jul 7, 2021
@geriux
geriux deleted the rnmobile/colors-update-changelog branch July 7, 2021 10:52
@github-actions github-actions Bot added this to the Gutenberg 11.1 milestone Jul 7, 2021
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
* Mobile - Update CHANGELOG: For color/background customization feature

* Add changelog PR id
@mokagio

mokagio commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

The Screenshots section of the PR description is mesmerizing to watch 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants