Repository navigation
Fix block crashes when an inner block is deleted in certain cases - #32399
Closed
david-szabo97 wants to merge 1 commit into
Closed
david-szabo97 wants to merge 1 commit into
david-szabo97 wants to merge 1 commit into
Conversation
david-szabo97
requested review from
Addison-Stavlo,
Copons,
JustinyAhin,
creativecoder,
ellatrix,
jeyip,
mattwiebe,
vindl and
youknowriad
June 2, 2021 11:45
Contributor
|
Size Change: +20 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
Member
Author
|
Superseded by #32088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31115
Description
In certain cases when you delete an inner block using backspace, then the inner block crashes before it's actually removed. Looks like it's something similar to #17013 . I tried to find the root of the issue but I just couldn't. Everything seems fine in the state object when the delete happens, but the inner block is still rendered after the data related to the inner block is removed from the store.
I was hoping #17092 should fix this as well. But looks like it's not 😄
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).