Repository navigation
Workflows: Run tests on release branches - #31354
Merged
Merged
Conversation
gziolo
approved these changes
Apr 29, 2021
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
Contributor
|
Cool, thanks @ockham To avoid manual checking, we should probably add a precheck to the release job. |
youknowriad
approved these changes
Apr 30, 2021
desrosj
pushed a commit
that referenced
this pull request
Jul 2, 2021
(cherry picked from commit 7063d86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gutenberg v10.5.1 was broken because it was missing an API that had been introduced by #31078 -- which had been merged into
trunk, but not cherry-picked into therelease/10.5branch.We aren't currently running our tests on
release/branches. Thus, a look at the branch's commit history might inspire false confidence, as it shows ✔️ signs next to most commits (even though those only reflect that the only workflow that we're currently running againstrelease/branches is passing -- the "Pull request automation" workflow):This PR enables 3 of our workflows (Static Analysis, Unit Tests, E2E Tests) to be run against
release/branches, in order to surface breakage more quickly.How has this been tested?
Bit tricky, since this needs a
release/branch. Maybe fork the repo, create a temporaryrelease/testbranch (based on this PR's branch), and check that branch's commit history?