Repository navigation
Make RNMobile Appium logs available - #29113
Merged
Merged
Conversation
When a RN Mobile test fails (e.g. `gutenberg-editor-gallery`), the cause of the error is sometimes unclear and access to the `appium-out.log` is needed. This PR uploads that log as a workflow artifact (similar to how screen recordings are uploaded currently), so they can be downloaded and viewed if needed.
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
Contributor
Author
|
I opted not to cherry-pick this commit onto this branch for now, since it could suppress the error by not calling |
guarani
marked this pull request as ready for review
February 18, 2021 21:58
2 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a RN Mobile E2E test fails (e.g.
gutenberg-editor-gallery), the cause of the error is sometimes unclear and access to theappium-out.logis needed. This PR uploads that log as a workflow artifact (similar to how screen recordings are uploaded currently), so they can be downloaded and viewed if needed.How has this been tested?
By verifying that the
appium-log.outfile is now downloadable on both React Native E2E Tests (iOS) and React Native E2E Tests (Android) tests.Screenshots
Types of changes
Improvement to RNMobile E2E tests to allow for easier debugging when tests fail.
Checklist: