Repository navigation
Reduces padding on highlight for drop down - #26572
Conversation
|
Size Change: +46 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
Confirmed, this fixes the issue: However, my golly that dropdown needs a lot of love. Why is the text gray? Why is it allcaps? (I know @aaronrobertshaw is struggling with this exact issue in #26444) Why is the popover borderless when not in focus? To be quite clear, none of this is your doing, and I really appreciate your taking a stab at improving this menu, it's clearly full of low hanging fruit. Here's the CSS as best I can tell: It seems to me the problem here is that panel titles are lumped in with the custom select control, when those should be separate. So I'd extract |
a32a237 to
efe42ce
Compare
| font-weight: 500; | ||
| } | ||
|
|
||
| .components-custom-select-control__menu li.is-highlighted { |
There was a problem hiding this comment.
Alright, I rebased this and removed the line that causes inheritance of the allcaps text in the custom dropdowns. That actually fixes the margin issue, so you can remove this line.
|
At some point the |
|
@jasmussen Ah goodness that was the last commit, I'll work out a way to solve that and get it ready. Thanks. |
1236fc3 to
2cafe52
Compare
|
@tellthemachines if this could get a final code review I think it might be able to slip in the group for the release. It's low priority so no stress if not, but as a block already released would fix a bug. I would love to know if I've done the removal of the file correctly and if not learn how to do that though. |
|
@karmatosed the Navigation Block isn't in Core yet, so this doesn't need to go into 5.6, but happy to help out with it anyway! The |
|
Thanks so much @tellthemachines, I've done that 🙏🏻 This still needs a code review, but should be ready for that now. |
|
Awesome, thanks. Let's get this PR in then and work can continue. |
|
Why was |
|
@ellatrix regarding this comment:
Happy to revert this merge if issue is problem though. |
|
Right, it should have been removed from the branch and synced with master? |
|
And no worries, it's easy enough to fix. It's been partially reverted to make the tests happy. Not sure if the rest should be reverted, but it's not causing any failures. |






This is a small change that fixes the drop-down spacing on highlight for the navigation block. It relates to suggestions in #26571
Before
After