Skip to content

Revert "[Try] Customizable toolbar contents (#23613)" - #25854

Merged
adamziel merged 1 commit into
masterfrom
revert/customizable-toolbar
Nov 27, 2020
Merged

adamziel merged 1 commit into
masterfrom
revert/customizable-toolbar

Conversation

@talldan

@talldan talldan commented Oct 6, 2020 •

Copy link
Copy Markdown
Contributor

This reverts commit 5078c43.

Description

Reverts the API introduced in #23613, which will be superseded by #25890.

While there's still a desire to add in-toolbar editing of items (Linking #23375, Image cropping), the approach taken in that PR isn't accessible as it replaces the DOM and results in focus loss.

I don't see a way to rework this existing API to be accessible, so I think it's best to start from scratch with something new.

This API is currently unused, so there should be no issue reverting.

@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take General Interface Parts of the UI which don't fall neatly under other labels. [Package] Block editor /packages/block-editor labels Oct 6, 2020
@talldan talldan self-assigned this Oct 6, 2020
@github-actions

github-actions Bot commented Oct 6, 2020 •

Copy link
Copy Markdown

Size Change: -5.69 kB (0%)

Total Size: 1.19 MB

Filename Size Change
build/a11y/index.js 1.14 kB -1 B
build/blob/index.js 665 B +1 B
build/block-editor/index.js 128 kB -5.55 kB (4%)
build/block-editor/style-rtl.css 11.2 kB -73 B (0%)
build/block-editor/style.css 11.2 kB -77 B (0%)
build/block-library/index.js 148 kB -12 B (0%)
build/block-serialization-default-parser/index.js 1.87 kB -2 B (0%)
build/blocks/index.js 48.1 kB +1 B
build/components/index.js 172 kB -35 B (0%)
build/compose/index.js 9.95 kB -1 B
build/core-data/index.js 14.8 kB +2 B (0%)
build/data-controls/index.js 828 B +1 B
build/date/index.js 11.2 kB +1 B
build/deprecated/index.js 769 B +1 B
build/edit-navigation/index.js 11.1 kB +1 B
build/edit-post/index.js 306 kB +6 B (0%)
build/edit-site/index.js 24 kB +12 B (0%)
build/edit-widgets/index.js 26.3 kB +7 B (0%)
build/editor/index.js 43.3 kB +1 B
build/element/index.js 4.62 kB +2 B (0%)
build/format-library/index.js 6.86 kB -4 B (0%)
build/html-entities/index.js 622 B -1 B
build/list-reusable-blocks/index.js 3.1 kB -1 B
build/notices/index.js 1.82 kB +4 B (0%)
build/nux/index.js 3.42 kB +1 B
build/plugins/index.js 2.56 kB +1 B
build/redux-routine/index.js 2.83 kB -3 B (0%)
build/reusable-blocks/index.js 2.92 kB +5 B (0%)
build/rich-text/index.js 13.4 kB +22 B (0%)
build/server-side-render/index.js 2.77 kB +1 B
build/shortcode/index.js 1.69 kB -3 B (0%)
build/token-list/index.js 1.27 kB +1 B
build/url/index.js 4.06 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/annotations/index.js 3.8 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/editor-rtl.css 8.96 kB 0 B
build/block-library/editor.css 8.96 kB 0 B
build/block-library/style-rtl.css 8.23 kB 0 B
build/block-library/style.css 8.23 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/data/index.js 8.8 kB 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.95 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.42 kB 0 B
build/edit-post/style.css 6.4 kB 0 B
build/edit-site/style-rtl.css 3.92 kB 0 B
build/edit-site/style.css 3.92 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.27 kB 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.54 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@adamziel

adamziel commented Oct 7, 2020 •

Copy link
Copy Markdown
Contributor

Not a blocker by any means, but just noting reverting these changes would also revert this nice side-effect of having CSS transitions in place:

2020-10-07 11-13-44 2020-10-07 11_14_21

I quite enjoyed the aesthetics of smooth resizing (vs instant change) so just flagging it here. CC @shaunandrews @mapk, maybe it would inspire some future work.

@gziolo

gziolo commented Nov 8, 2020

Copy link
Copy Markdown
Member

Should it be merged or closed now that a few weeks passed? 😃

@adamziel

adamziel commented Nov 23, 2020 •

Copy link
Copy Markdown
Contributor

@talldan this has conflicts now, would you solve them and ping me? Let's get this PR in.

@talldan
talldan force-pushed the revert/customizable-toolbar branch 2 times, most recently from 951c70c to 64a400f Compare November 26, 2020 08:19
@talldan
talldan force-pushed the revert/customizable-toolbar branch from 64a400f to e92e0ec Compare November 26, 2020 08:24
@talldan

talldan commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

Rebased!

@adamziel adamziel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamziel
adamziel merged commit c35d9af into master Nov 27, 2020
@adamziel
adamziel deleted the revert/customizable-toolbar branch November 27, 2020 15:28
@github-actions github-actions Bot added this to the Gutenberg 9.5 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

General Interface Parts of the UI which don't fall neatly under other labels. [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants