Skip to content

Try: Reduced inserter hover delay. - #23046

Merged
jasmussen merged 1 commit into
masterfrom
try/alt-hover-delay
Jun 12, 2020
Merged

jasmussen merged 1 commit into
masterfrom
try/alt-hover-delay

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

Alternative to #23043, props @MichaelArestad.

This one is faster, but still delayed.

alternative

Alternative to #23043, props @MichaelArestad.

This one is faster, but still delayed.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Jun 10, 2020
@jasmussen
jasmussen requested a review from MichaelArestad June 10, 2020 07:20
@jasmussen jasmussen self-assigned this Jun 10, 2020
@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.77 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 11.8 kB 0 B
build/block-editor/style.css 11.8 kB 0 B
build/block-library/editor-rtl.css 7.88 kB 0 B
build/block-library/editor.css 7.89 kB 0 B
build/block-library/index.js 127 kB 0 B
build/block-library/style-rtl.css 7.72 kB 0 B
build/block-library/style.css 7.72 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.32 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.25 kB 0 B
build/edit-navigation/style-rtl.css 918 B 0 B
build/edit-navigation/style.css 919 B 0 B
build/edit-post/index.js 303 kB 0 B
build/edit-post/style-rtl.css 5.6 kB 0 B
build/edit-post/style.css 5.6 kB 0 B
build/edit-site/index.js 16.7 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.8 kB 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@MichaelArestad

Copy link
Copy Markdown
Contributor

@jasmussen This is an improvement over mine because the jank isn't noticeable. That said, I think the jank is unrelated to animation speed. I think it's an issue with the inserter actually moving. In this PR I was able to see some jank (just looking at my cursor icon) and even reproduce the inserter showing up in the wrong spot:

image

@chrisvanpatten

Copy link
Copy Markdown
Contributor

This is definitely an improvement but the delay is so subtle that my first instinct was wondering if my browser had glitched.

I also noticed some slightly jumpiness in Safari, possibly due to subpixel rounding related to the animation. The icon seems to move ever so slightly.

@chrisvanpatten

chrisvanpatten commented Jun 10, 2020 •

Copy link
Copy Markdown
Contributor

I just tried #23043 and I have to admit other than the slight animation wonkiness the timing feels a lot better. It feels responsive without me wondering if Chrome just crashed 😅

@MichaelArestad

Copy link
Copy Markdown
Contributor

@chrisvanpatten Looks like it's a bug with the inserter teleporting. Your Chrome is fine.

@jasmussen

Copy link
Copy Markdown
Contributor Author

Thanks for all the feedback. It looks like we have a few paths forward. We can either:

  1. Merge this PR (or this PR with feedback tweaks) that increases the speed today, then look for a fix to Michael's issue, and then followup with a PR to improve the syntax.
  2. Look for a fix to Michael's issue and "do it right".

I'm leaning towards 1 for the time being, because people are seeming to think the sibling inserter has been removed entirely, due to the current delay. But open to thoughts!

@MichaelArestad

Copy link
Copy Markdown
Contributor

@jasmussen because it's such a trivial PR for me to make (and I have the values memorized at this point), I think we should go ahead with option 1 until that bug gets fixed.

@jasmussen
jasmussen marked this pull request as ready for review June 12, 2020 05:41
@jasmussen

Copy link
Copy Markdown
Contributor Author

Cool, feel free to give me a thumbs up for this one then. Thanks.

@jasmussen
jasmussen merged commit c0d5301 into master Jun 12, 2020
@jasmussen
jasmussen deleted the try/alt-hover-delay branch June 12, 2020 08:47
@github-actions github-actions Bot added this to the Gutenberg 8.4 milestone Jun 12, 2020
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants