Skip to content

Remove no longer necessary selection checks - #22500

Merged
mchowning merged 1 commit into
rnmobile/release-1.28.1from
rnmobile/issue_9832/span_index_exceptions
May 25, 2020
Merged

mchowning merged 1 commit into
rnmobile/release-1.28.1from
rnmobile/issue_9832/span_index_exceptions

Conversation

@mchowning

Copy link
Copy Markdown
Contributor

Remove checks that are now handled on the native side by Android.

See the related gutenberg-mobile PR for further description and testing steps: wordpress-mobile/gutenberg-mobile#2279

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@mchowning
mchowning requested a review from geriux May 20, 2020 14:52
@mchowning mchowning self-assigned this May 20, 2020
@mchowning mchowning added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 20, 2020
}
selection = {
start: newSelectionStart,
end: newSelectionEnd,

@mchowning mchowning May 20, 2020 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the three selection checks, this is the only one that tries to do more than just setting the selection to null if there is a problem, so I decided to leave it in even though I think we could probably remove it as well now.

@geriux

geriux commented May 20, 2020

Copy link
Copy Markdown
Member

We could remove this and this as well right? What do you think?

@mchowning
mchowning force-pushed the rnmobile/issue_9832/span_index_exceptions branch from 40fb567 to 8f5a873 Compare May 20, 2020 17:42
@github-actions

github-actions Bot commented May 20, 2020 •

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.61 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 761 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 10.3 kB 0 B
build/block-editor/style.css 10.3 kB 0 B
build/block-library/editor-rtl.css 7.12 kB 0 B
build/block-library/editor.css 7.12 kB 0 B
build/block-library/index.js 115 kB 0 B
build/block-library/style-rtl.css 7.38 kB 0 B
build/block-library/style.css 7.38 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 180 kB 0 B
build/components/style-rtl.css 17 kB 0 B
build/components/style.css 16.9 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 4.41 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/index.js 28 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 12.1 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/index.js 8.37 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.14 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

These are now handled on the native side
@mchowning
mchowning force-pushed the rnmobile/issue_9832/span_index_exceptions branch from 8f5a873 to 948e05e Compare May 20, 2020 18:30
@mchowning

mchowning commented May 20, 2020 •

Copy link
Copy Markdown
Contributor Author

We could remove this and this as well right? What do you think?

You're absolutely right @geriux ! I forgot to remove those, but I have now. Thanks!

@geriux geriux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's always good to see some code refactor =)

@mchowning
mchowning merged commit 219b7ea into rnmobile/release-1.28.1 May 25, 2020
@mchowning
mchowning deleted the rnmobile/issue_9832/span_index_exceptions branch May 25, 2020 14:32
mchowning added a commit that referenced this pull request May 26, 2020
* RNMobile - Starter Page Templates - Portfolio: adds missing ids for galleries (#22321)

* Fix margin for the post-title (#22331)

* Fix margin for the post-title

Add 4px margin from the edges of the screen and adjust the alignment
of text.

* Only apply margins on the left and right edges.

* Correct buttons appender (#22362)

* Remove no longer necessary selection checks (#22500)

These are now handled on the native side

Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants