Repository navigation
[ Latest Posts ] Fix link for read more markup - #20917
Merged
Merged
Conversation
draganescu
requested review from
Soean,
ajitbohra,
jorgefilipecosta,
talldan and
youknowriad
as code owners
March 16, 2020 08:49
|
Size Change: +4 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
fix/latest-posts-read-more-html
branch
from
March 16, 2020 11:28
9498031 to
0ed8a7d
Compare
adamziel
approved these changes
Mar 16, 2020
youknowriad
reviewed
Mar 16, 2020
| 'target="_blank" rel="noopener noreferrer">' + | ||
| '" target="_blank" rel="noopener noreferrer">' + | ||
| __( 'Read more' ) + | ||
| '</a>' |
Contributor
There was a problem hiding this comment.
Any reason why we're concatening HTML and using RawHTML. security-wise, it seems better to just use JSX.
Contributor
Author
There was a problem hiding this comment.
i don't think there is a reason :)
Contributor
Author
There was a problem hiding this comment.
Howdy @youknowriad and @mcsf a fix is ready in #21170
Member
|
Merging this PR as it was approved and seems to fix the problem. |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20783
How has this been tested?
Screenshots