Skip to content

Lowercase block editor in the Welcome Guide to match core standard - #20293

Merged
mkaz merged 2 commits into
WordPress:masterfrom
garretthyder:lowercase-block-editor
Feb 21, 2020
Merged

mkaz merged 2 commits into
WordPress:masterfrom
garretthyder:lowercase-block-editor

Conversation

@garretthyder

@garretthyder garretthyder commented Feb 18, 2020 •

Copy link
Copy Markdown
Contributor

Description

Following #14205 and the core spelling Best Practice I've lowercased 'Block Editor' within the Welcome Guide.

How has this been tested?

Manually checked this didn't break anything and updated the nux tests.

Types of changes

Non-breaking text change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Soean

Soean commented Feb 19, 2020

Copy link
Copy Markdown
Member

We should also change Block Library to block library in the welcome guide.

@garretthyder

Copy link
Copy Markdown
Contributor Author

Thanks @Soean I've updated the PR to also lowercase Block Library where appropriate.

@mkaz
mkaz merged commit 2971efa into WordPress:master Feb 21, 2020
@github-actions github-actions Bot added this to the Gutenberg 7.6 milestone Feb 21, 2020
@garretthyder
garretthyder deleted the lowercase-block-editor branch February 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants