Skip to content

Add format-js to scripts README for Prettier support - #19766

Closed
mkaz wants to merge 4 commits into
masterfrom
docs/scripts-prettier
Closed

mkaz wants to merge 4 commits into
masterfrom
docs/scripts-prettier

Conversation

@mkaz

@mkaz mkaz commented Jan 20, 2020

Copy link
Copy Markdown
Member

Description

Updates the scripts README with format-js instructions for Prettier support.
This should either be cherry picked into #18048 or merged after.

Types of changes

Documentation, confirm it works as expected.

@mkaz mkaz added [Type] Developer Documentation Documentation for developers [Tool] WP Scripts /packages/scripts labels Jan 20, 2020

@gziolo gziolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @mkaz. I’d appreciate sanity check from @jsnajdr.

Comment thread packages/scripts/README.md Resolved
Comment thread packages/scripts/README.md Resolved
Comment thread packages/scripts/README.md Resolved

@ntwb ntwb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to update the instances of format-js to format:js in line with the lint:* nomenclature.

There are already a couple of instances where format:js was used to

Co-Authored-By: Stephen Edgar <stephen@netweb.com.au>
Comment thread packages/scripts/README.md Resolved

@ntwb ntwb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mkaz

mkaz commented Jan 29, 2020

Copy link
Copy Markdown
Member Author

Closing in favor of #19946

@mkaz mkaz closed this Jan 29, 2020
@mkaz
mkaz deleted the docs/scripts-prettier branch January 29, 2020 14:19
@gziolo

gziolo commented Jan 29, 2020

Copy link
Copy Markdown
Member

I see I reviewed it and missed when working on my patch 😞

The good part is that the version I pushed looks similar :)

@mkaz

mkaz commented Jan 29, 2020

Copy link
Copy Markdown
Member Author

I've done similar, so no worries. There's so much happening hard to keep track of every PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] WP Scripts /packages/scripts [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants