Skip to content

Popover: remove buffer options - #19283

Merged
ellatrix merged 1 commit into
masterfrom
remove/popover-buffer
Dec 20, 2019
Merged

ellatrix merged 1 commit into
masterfrom
remove/popover-buffer

Conversation

@ellatrix

@ellatrix ellatrix commented Dec 20, 2019 •

Copy link
Copy Markdown
Member

Description

These options were added in #17867, but I realised recently that we could just use a margin. 🙈
These options were not documented and not part of any WordPress release, so they are safe to remove.

How has this been tested?

Check the inline toolbar position for the image block. There should be some space between the caption text and the toolbar.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix
ellatrix force-pushed the remove/popover-buffer branch from 26e83cb to 01320e7 Compare December 20, 2019 18:27
@ellatrix
ellatrix merged commit 56cd1df into master Dec 20, 2019
@ellatrix
ellatrix deleted the remove/popover-buffer branch December 20, 2019 19:13

.components-popover__content {
min-width: auto;
margin-bottom: 6px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this seem simpler, from a user's perspective, it's less obvious. I wonder if keeping the prop and make it work by adding a margin could be the best of both worlds. No urgency though, just a thought in case this becomes a common pattern.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience with #18779, it does seem easier at first to have an option like this, but this option is way less flexible than CSS. In CSS you can adjust it based on classes etc. It's also something that's clearly styling and should ideally be done in CSS if possible.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants