Repository navigation
Improve and simplify reusable block styles - #18903
Merged
Merged
Conversation
ZebulanStanphill
requested review from
Soean,
ajitbohra,
ellatrix,
jorgefilipecosta,
talldan and
youknowriad
as code owners
December 4, 2019 04:48
jasmussen
approved these changes
Dec 4, 2019
jasmussen
left a comment
Contributor
There was a problem hiding this comment.
Very nice work, thank you! I left one question, but otherwise this seems good and tests well for me.
Reusable blocks as a whole provides an interesting design challenge worth exploring additionally, perhaps as part of efforts in #18667.
ZebulanStanphill
force-pushed
the
update/reusable-block-outline-styles
branch
from
December 4, 2019 14:57
180dfb9 to
ec82884
Compare
Member
Author
|
Addressed feedback. |
Member
Author
|
I should note that there is currently a styling issue where the blue select color is not applied in dark theme mode, but this issue is also present in |
ZebulanStanphill
force-pushed
the
update/reusable-block-outline-styles
branch
from
December 5, 2019 15:17
ec82884 to
61bcbf9
Compare
Member
Author
|
Rebased now that #18902 is merged. Will merge this PR after tests pass. |
Member
Author
|
I created #18958 to fix the dark mode issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Currently includes / blocked by #18902.)#18902 is now merged and has been removed from this PR.Inspired by changes in #18105 and #18862 to reduce the UI weight of unselected blocks, I made this PR to simplify and improve the reusable block styles. I've made the following changes:
<ReusableBlockIndicator />). Showing these indicators goes against the general idea of unselected blocks looking like the front-end, and they weren't very useful in the first place, in my opinion. You could hover the indicator to see the reusable block title, but this is a rather hidden aspect that I didn't even know about until making this PR, and it is easier to just select the block if you want to see its title. Additionally, it seems weird to keep the indicators now that the hover labels have been removed.I've considered changing reusable blocks to use solid outlines like every other block, but I'm not entirely sure about that change yet, so I'll leave it for another PR.
Screenshots
Note that when I took these screenshots, #18901 was not fixed in
master, but it was in this branch. That's why the reusable blocks are taller in the "before" screenshots.Unselected
Before:

After:

Selected (select tool)
Before:

After:

Selected (edit tool)
Before:

After (unchanged except for #18901 being fixed):

Checklist: