Skip to content

Edit Post: Render metaboxes as single seamless unit - #18873

Merged
aduth merged 1 commit into
masterfrom
update/meta-margins
Dec 3, 2019
Merged

aduth merged 1 commit into
masterfrom
update/meta-margins

Conversation

@aduth

@aduth aduth commented Dec 2, 2019

Copy link
Copy Markdown
Member

Related: #18044, #18762

This pull request seeks to improve styling interoperability between the meta box area and a themed editor background. As seen in the "Before" screenshot below, there is a plain-white margin gap which appears above the meta box area. With these changes, the margin is removed, and meta boxes changed to being contained within a single container element.

Before After
Before After

Testing Instructions:

In the default development environment, you can enable the "Gutenberg Test Plugin, Meta Box" plugin to display a meta box in the metabox area.

Furthermore, I used Advanced Custom Fields to add many more meta boxes. ACF does not appear to have the option to make a meta box for the "advanced" context, so I tested this by manually editing this line to 'advanced',.

  1. Navigate to Posts > Add New
  2. Verify with meta boxes shown, or with no meta boxes shown, that there is no gap between meta box area (if present) and the rest of the editor canvas

@aduth aduth added Needs Design Feedback Needs general design feedback. [Feature] Meta Boxes A draggable box shown on the post editing screen [Package] Edit Post /packages/edit-post [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Dec 2, 2019
@aduth
aduth requested a review from youknowriad December 2, 2019 16:57
@aduth
aduth requested a review from talldan as a code owner December 2, 2019 16:57
@karmatosed
karmatosed self-requested a review December 2, 2019 20:46

@karmatosed karmatosed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From design feedback, approving this PR. Great little tidy up.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Dec 2, 2019
@aduth
aduth merged commit d89595b into master Dec 3, 2019
@aduth
aduth deleted the update/meta-margins branch December 3, 2019 15:39
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Meta Boxes A draggable box shown on the post editing screen [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Package] Edit Post /packages/edit-post

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants