Repository navigation
Edit Post: Render metaboxes as single seamless unit - #18873
Merged
Merged
Conversation
karmatosed
self-requested a review
December 2, 2019 20:46
karmatosed
approved these changes
Dec 2, 2019
karmatosed
left a comment
Member
There was a problem hiding this comment.
From design feedback, approving this PR. Great little tidy up.
youknowriad
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #18044, #18762
This pull request seeks to improve styling interoperability between the meta box area and a themed editor background. As seen in the "Before" screenshot below, there is a plain-white margin gap which appears above the meta box area. With these changes, the margin is removed, and meta boxes changed to being contained within a single container element.
Testing Instructions:
In the default development environment, you can enable the "Gutenberg Test Plugin, Meta Box" plugin to display a meta box in the metabox area.
Furthermore, I used Advanced Custom Fields to add many more meta boxes. ACF does not appear to have the option to make a meta box for the "advanced" context, so I tested this by manually editing this line to
'advanced',.