Repository navigation
Conversation
|
In use, this looks great, and performs well. I'm actually confused how this works, and the text still looks crisp even at 1.01 scale. Black magic! |
As noted by @youknowriad in #core-editor chat today, this extra class may not be a possibility. That being the case, I pushed a different solution up in 786c0a6. What this does is target appenders and placeholders inside of selected blocks that have the extra padding, and applies a second animation to them. The original animation scales things from Before: After: @jasmussen, I'd love your thoughts on this approach. |
|
I definitely think that animation helps smooth out this experience, which can be slightly jarring otherwise. Given the recent feedback on the clickthrough, I think this is one of the ones to sit on for a little bit as we look to explore putting everything in its right place. But the technique — the black magic that makes this work — definitely keep that one in the old noodle, as I suspect we'll want to use that in many, many contexts. |
|
#18105 removed the InnerBlocks selection padding, so I think this PR can be closed. |


When it's necessary to prevent overlap, #14961 adds some additional padding to
.editor-inner-blocks. This additional padding is currently only provided for the Group block, and for the Columns block.In that issue, we discussed adopting a very subtle
scale()animation so that the addition of that extra space wasn't so jarring. This PR implements that animation.Before:
After: (The GIF is slowed down to make the animation more visible)
This seems pretty subtle, and helps make this smoother by just a little bit. The only issue I'm seeing is that it is unnecessarily applied to placeholders as well:
I don't think there's a way to turn this off, without the addition of a
has-placeholderclass on the parent block to hook into. This seemed like it might be a possibility during an earlier discussion.