Skip to content

Update dynamic blocks documentation - #16450

Merged
mkaz merged 2 commits into
WordPress:masterfrom
jodamo5:patch-2
Jul 17, 2019
Merged

mkaz merged 2 commits into
WordPress:masterfrom
jodamo5:patch-2

Conversation

@jodamo5

@jodamo5 jodamo5 commented Jul 7, 2019

Copy link
Copy Markdown
Contributor

#16374 Description
Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request. Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

How has this been tested?

Most changes here are simply text changes to improve the understanding. The InnerBlocks explanation has been tested on both development and live sites.

Types of changes

Just further explanations in the documentation.

Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.
@Soean Soean added the [Type] Developer Documentation Documentation for developers label Jul 8, 2019
@jodamo5

jodamo5 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor Author

One of the tests failed, but seems like a mistake, as no code was actually changed on this file - just text changes. Can someone look into this please?

@Soean

Soean commented Jul 9, 2019 •

Copy link
Copy Markdown
Member

@jodamo5 We had some issues with the tests yesterday. I restarted them and now they are fine :-)

@jodamo5

jodamo5 commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @Soean. Tests have passed. Can someone please merge this in? Thanks.

@mkaz mkaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion to show how to save the content. If there is a link to an example block that would be good to include but not necessary.

…creating-dynamic-blocks.md


Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>

@mkaz mkaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates!

@mkaz
mkaz merged commit 07f19f1 into WordPress:master Jul 17, 2019
@github-actions github-actions Bot added this to the Gutenberg 6.1 milestone Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants