Repository navigation
Update onSplit method on RN blocks to the latest version. - #15762
Merged
Merged
Conversation
This commit updates the native richtext component to use the latest version of onSplit. It also updates the custom paragraph and heading blocks to use the new onSplit.
1 task
Contributor
|
Code looks 👍 Testing on both android on ios (demo app)... |
Contributor
|
Discovered a bug when merging blocks. I don't think it's related to this PR but I'd like to investigate a bit more. Here is how to reproduce (on android):
This seems to be happening because |
…etween componentWillReceiveProps and componentDidUpdate
Contributor
|
Pushed a fix for the (seemingly unrelated) bug, feel free to test on your end. |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit updates the native richtext component to use the latest version of onSplit.
It also updates the custom paragraph and heading blocks to use the new onSplit.
How has this been tested?
Use this PR on GB mobile to test: wordpress-mobile/gutenberg-mobile#1013
Screenshots
Types of changes
Checklist: