Skip to content

Add <Button></Button> tags back into the Button readme - #14964

Merged
gziolo merged 1 commit into
masterfrom
update/buton-readme
Apr 14, 2019
Merged

gziolo merged 1 commit into
masterfrom
update/buton-readme

Conversation

@kjellr

@kjellr kjellr commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

Adds <Button isDefault> and </Button> tags back into the code example in the Button readme. These were removed erroneously in #14194.

Thanks @nickylimjj for pointing this out.

@kjellr kjellr added [Type] Developer Documentation Documentation for developers [Component] Button Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Apr 12, 2019
@kjellr
kjellr requested a review from davewhitley April 12, 2019 19:02
@kjellr kjellr self-assigned this Apr 12, 2019

@Aurorum Aurorum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gziolo
gziolo merged commit dd9bf47 into master Apr 14, 2019
@gziolo
gziolo deleted the update/buton-readme branch April 14, 2019 13:34
@gziolo gziolo added this to the 5.5 (Gutenberg) milestone Apr 14, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants