Skip to content

[Mobile] Fix caret position after inline paste. - #14893

Merged
mkevins merged 3 commits into
masterfrom
fix/caret-position-after-inline-paste
Apr 12, 2019
Merged

mkevins merged 3 commits into
masterfrom
fix/caret-position-after-inline-paste

Conversation

@mkevins

@mkevins mkevins commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

Description

This PR fixes part of this issue: wordpress-mobile/gutenberg-mobile#828 , specifically, when inline content is pasted.

How has this been tested?

This has been tested using the steps here:
wordpress-mobile/gutenberg-mobile#828 (comment)

Screenshots

Types of changes

This is a bug fix, but currently only resolves a part of the original issue. I'm leaving this as a draft PR to gather more information. It currently serves as an incremental improvement, but I'd like to have some consensus on whether it makes sense to wait for a full fix (for both inline and multi-line content) before merging.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mkevins

mkevins commented Apr 10, 2019

Copy link
Copy Markdown
Contributor Author

After some consideration, I think this is ready for review. It should have minimal impact on other areas of the code, and fixes an existing issue. The other parts of the original issue (i.e. pasting multi-line content) can be addressed in another PR.

@mkevins
mkevins marked this pull request as ready for review April 10, 2019 12:12
@mkevins
mkevins requested review from etoledom and mzorz April 10, 2019 12:17
@etoledom

Copy link
Copy Markdown
Contributor

The other parts of the original issue (i.e. pasting multi-line content) can be addressed in another PR.

Completely agree! 👍

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mkevins ! It's working perfectly 🎉
Tested on iOS and Android ✅

@mkevins

mkevins commented Apr 11, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @etoledom !

@mkevins
mkevins merged commit 3ec48d6 into master Apr 12, 2019
@mkevins
mkevins deleted the fix/caret-position-after-inline-paste branch April 12, 2019 09:38
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants