Skip to content

Fix/post title borders in code editor - #14771

Merged
kjellr merged 5 commits into
masterfrom
fix/post-title-borders-in-code-editor
Apr 3, 2019
Merged

kjellr merged 5 commits into
masterfrom
fix/post-title-borders-in-code-editor

Conversation

@kjellr

@kjellr kjellr commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

Eliminates the thick block border on the post title and permalink box, when the user is in the Code Editor. As mentioned in #14761 (review)


Before

Screen Shot 2019-04-02 at 9 40 03 AM

After

Screen Shot 2019-04-02 at 9 35 57 AM

@kjellr kjellr added the [Type] Bug An existing feature does not function as intended label Apr 2, 2019
@kjellr kjellr self-assigned this Apr 2, 2019
@kjellr
kjellr requested review from jasmussen and youknowriad April 2, 2019 13:43
@kjellr
kjellr requested a review from chrisvanpatten as a code owner April 2, 2019 13:43
}

// Hide the thick block border in the Code Editor.
.edit-post-text-editor__body .editor-post-title & {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're in the editor module, we should reference edit-post styles. If we were to override this, it should happen in the edit-post module where we use the post title component.

}

// Hide the thick block border in the Code Editor.
.edit-post-text-editor__body & {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should be fixed in dc24fa6

@kjellr
kjellr merged commit c6cb4c1 into master Apr 3, 2019
@kjellr
kjellr deleted the fix/post-title-borders-in-code-editor branch April 3, 2019 14:29
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
aduth pushed a commit that referenced this pull request Apr 16, 2019
* Remove thick left border for the title in the code editor.

* Remove thick left border from the permalink field in the code editor.

* Move styles into the `edit-post` module.

* Remove no-longer-necessary style change.

* Remove unnecessary styles.
aduth pushed a commit that referenced this pull request Apr 16, 2019
* Remove thick left border for the title in the code editor.

* Remove thick left border from the permalink field in the code editor.

* Move styles into the `edit-post` module.

* Remove no-longer-necessary style change.

* Remove unnecessary styles.
This was referenced Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants