Repository navigation
NPM Package JSON Lint Config: Remove is-plain-obj dependency - #14751
Merged
Merged
Conversation
aduth
requested review from
ajitbohra,
gziolo,
nerrad and
youknowriad
as code owners
April 1, 2019 16:00
nerrad
approved these changes
Apr 1, 2019
nerrad
left a comment
Contributor
There was a problem hiding this comment.
Was is-plain-obj initially used due to concern about the unnecessary size of the 'lodash' dependency?
Member
Author
|
@nerrad It was originally part of the |
This was referenced Apr 15, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #7556
This pull request seeks to use Lodash's
isPlainObjectinstead of the standaloneis-plain-objpackage. This is intended to consolidate to reduce the overall number of packages we depend upon for the project.Testing Instructions:
Verify unit tests pass: