Repository navigation
Fix property name in PluginBlockSettingsMenuItem - #14741
Conversation
It’s an upstream bug, see WordPress/gutenberg#14741
|
In my own testing example, I used Thanks for catching this @swissspidy I think it'll be better to fix it the other way round: rename the |
Wouldn't it be considered breaking for those which would have used |
Indeed, but I am not sure how many people that really did. I'd say most people go by the documentation, which means changing everything to I suppose we could just do |
Is it breaking if it never worked? 😆 |
|
Fair enough :-) I'll change it to |
Frustratingly, it's not all consistent. The I'd say as far as not creating further inconsistency, I guess the documentation may have been misled by the argument of this function? |
|
It'll be nice if we changed the |
Description
In #7895,
PluginBlockSettingsMenuItemwas made extensible for plugin developers.There was a slight oversight though regarding the
allowedBlockNamesprop. While the documentation was referring toallowedBlockNames, the code was actually checking forallowedBlocks,How has this been tested?
I extended the settings menu by using the examples from the documentation and verified that
allowedBlocksnow is properly documented as such.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: