Skip to content

[Mobile] Accessibility Mark I - Button - #14697

Merged
etoledom merged 2 commits into
masterfrom
rnmobile/accessibility-mark-i
Apr 3, 2019
Merged

etoledom merged 2 commits into
masterfrom
rnmobile/accessibility-mark-i

Conversation

@etoledom

@etoledom etoledom commented Mar 29, 2019 •

Copy link
Copy Markdown
Contributor

This PR improves the Accessibility features of the Button component.

To test:

@etoledom
etoledom requested a review from pinarol March 29, 2019 09:32
@etoledom etoledom self-assigned this Mar 29, 2019
@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 29, 2019
@etoledom
etoledom marked this pull request as ready for review March 29, 2019 09:32

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with steps on parent PR

@Tug Tug left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etoledom
etoledom merged commit 342961e into master Apr 3, 2019
@etoledom

etoledom commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

Thank you both!

@etoledom
etoledom deleted the rnmobile/accessibility-mark-i branch April 3, 2019 07:16
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants