Skip to content

Add documentation for MediaPlaceholder props. - #14645

Merged
jorgefilipecosta merged 1 commit into
masterfrom
add/documentation-for-mediaplaceholder-props
Mar 28, 2019
Merged

jorgefilipecosta merged 1 commit into
masterfrom
add/documentation-for-mediaplaceholder-props

Conversation

@jorgefilipecosta

Copy link
Copy Markdown
Member

Description

This PR just adds documentation for the MediaPlaceholder props.
I noticed during a recent change that the props were not documented.

How has this been tested?

This PR just affects the documentation.

@gziolo gziolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see all those props documented. Thank you for working on it. I left two comments where I would expect to learn more details.


## Props

### accept

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be clarified what's the difference between accept and allowedTypes, if any?


### onSelect

Callback called when the files are selected/uploaded, the selected media are passed as an argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the selected media are passed as an argument

In what format?

@jorgefilipecosta
jorgefilipecosta force-pushed the add/documentation-for-mediaplaceholder-props branch from 6fc0288 to 5065d97 Compare March 28, 2019 11:22
@jorgefilipecosta
jorgefilipecosta force-pushed the add/documentation-for-mediaplaceholder-props branch from 5065d97 to 223ed23 Compare March 28, 2019 11:23
@jorgefilipecosta
jorgefilipecosta merged commit a66fa9b into master Mar 28, 2019
@jorgefilipecosta
jorgefilipecosta deleted the add/documentation-for-mediaplaceholder-props branch March 28, 2019 12:59
@jorgefilipecosta

Copy link
Copy Markdown
Member Author

Thank you for the review @gziolo your feedback was applied before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants