Repository navigation
Typo fix in a documentation MD file - #14597
Merged
Merged
Conversation
elhardoum
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki,
oandregal and
youknowriad
as code owners
March 24, 2019 10:42
gziolo
approved these changes
Mar 25, 2019
gziolo
left a comment
Member
There was a problem hiding this comment.
Good catch, thank you for fixing it 👍
Member
|
@dd32 or @tellyworth, can you further investigate whether there were any changes in Gutenberg handbook which cause 404 errors? |
Member
|
All links should work properly after this patch https://meta.trac.wordpress.org/changeset/8503 applied by @dd32. @elhardoum, can you confirm you no longer see 404 pages when navigating links? |
Contributor
Author
|
@gziolo can confirm, no more 404 pages on that handbook page. Thanks for assisting on this! |
This was referenced Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've updated a simple typo replacing
REAMD.mdtoREADME.md. The wp-org docs link to many 404 pages though, which I am not sure of the docs build process, but I believe wp-docs backend takes slugs and markdown sources from thedocs/manifest.jsonfile.Here are the 404 links in this page:
https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/plugin-sidebar-0/plugin-sidebar-1-up-and-running/
[registerPlugin](/packages/plugins/README.md)Correct link: https://wordpress.org/gutenberg/handbook/designers-developers/developers/packages/packages-plugins/
[createElement](/packages/element/README.md)Correct link: https://wordpress.org/gutenberg/handbook/designers-developers/developers/packages/packages-element/
[packages](/docs/designers-developers/developers/packages.md)Correct link: https://wordpress.org/gutenberg/handbook/designers-developers/developers/packages/
This link on the other hand is working:
How has this been tested?
No.
Screenshots
Types of changes
Checklist: