Skip to content

Allow failures on php versions below 5.5 - #14541

Merged
gziolo merged 1 commit into
masterfrom
try/allow_failures_below_56
Mar 29, 2019
Merged

gziolo merged 1 commit into
masterfrom
try/allow_failures_below_56

Conversation

@aaronjorbin

Copy link
Copy Markdown
Member

This is a follow up to https://core.trac.wordpress.org/changeset/44950

Based on the docs - https://docs.travis-ci.com/user/build-matrix/#rows-that-are-allowed-to-fail - The allow_failures entry needs to exactly match the jobs.

@youknowriad

Copy link
Copy Markdown
Contributor

What's the reasoning here, why not just remove all the jobs for php 5.5 and lower?

@aaronjorbin

Copy link
Copy Markdown
Member Author

Has the plugin dropped support for WP 5.1? Until that happens, it should still work on old php versions.

@youknowriad

Copy link
Copy Markdown
Contributor

Good point @aaronjorbin Let's keep them for some time then.

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too quick, why do we have two jobs for these versions now?

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read the description of the PR. Sorry for the back and forth.

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Mar 29, 2019
@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
@gziolo
gziolo merged commit edf6b37 into master Mar 29, 2019
@gziolo
gziolo deleted the try/allow_failures_below_56 branch March 29, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants