Skip to content

Better center tooltip content - #14473

Merged
afercia merged 1 commit into
masterfrom
update/tooltips-content-alignment
Mar 16, 2019
Merged

afercia merged 1 commit into
masterfrom
update/tooltips-content-alignment

Conversation

@afercia

@afercia afercia commented Mar 16, 2019

Copy link
Copy Markdown
Contributor

Fixes #14472.

On Windows, keyboard shortcuts within tooltips are longer than on macOS, thus the text is not centered:

chrome windows

This PR moves text-align: center; from the shortcut text to the tooltip content container.

If you can't test on Windows, you can try:

  • use Chrome and open the dev tools > Sources tab
  • hover on the Redo button
  • press F8: you're now in "paused in debugger" mode
  • switch to the dev tools Elements tab
  • search for the keyboard shortcut text and replace it with a longer text:

Screenshot 2019-03-16 at 10 49 41

  • verify the text is centered

@afercia
afercia requested a review from chrisvanpatten as a code owner March 16, 2019 10:35

@chrisvanpatten chrisvanpatten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@afercia
afercia merged commit 5b37ee7 into master Mar 16, 2019
@afercia
afercia deleted the update/tooltips-content-alignment branch March 16, 2019 14:24
@youknowriad youknowriad added this to the 5.3 (Gutenberg) milestone Mar 18, 2019
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants