Skip to content

Raw handling: update strikethrough - #14430

Merged
youknowriad merged 1 commit into
masterfrom
add/raw-handling-s
Mar 18, 2019
Merged

youknowriad merged 1 commit into
masterfrom
add/raw-handling-s

Conversation

@ellatrix

Copy link
Copy Markdown
Member

Description

Split out from #14429.
Follow up to #14389.

Adds s to the phrasing content schema for raw handling.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Mar 14, 2019
@ellatrix ellatrix added this to the 5.3 (Gutenberg) milestone Mar 14, 2019

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I pasted <p>Hello <span style="text-decoration-line: line-through">World</span></p>on master and I got <p>Hello <del>World</del></p>, in this branch I got <p>Hello <s>World</s></p>. Would it be possible to add a test case covering this before the merge?

@youknowriad youknowriad removed this from the 5.3 (Gutenberg) milestone Mar 18, 2019
@youknowriad
youknowriad merged commit 5e74833 into master Mar 18, 2019
@youknowriad youknowriad added this to the 5.3 (Gutenberg) milestone Mar 18, 2019
@aduth
aduth deleted the add/raw-handling-s branch March 18, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants